Add support for decoding back to parquet #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livinlefevreloca
commented
Apr 8, 2024
|
|
||
| // If the tuple length is 0xffff we have reached the end of the | ||
| // snapshot and we can break the loop and finish the batch. | ||
| if tuple_len == 0xffff { |
There was a problem hiding this comment.
Add comment explaining this cannot get a false positive since we will never bee mid tuple when we run the code to read the tuple length
livinlefevreloca
commented
Apr 8, 2024
| // decoder specfied via the schema. | ||
| for decoder in self.decoders.iter_mut() { | ||
| // If local_buf has been fully consumed and we have not read any rows, | ||
| // return a BatchDecodeResult::Incomplete. |
There was a problem hiding this comment.
Add comment expaining this is possible if we are mid tuple and we happen to run out of data exactly on the column boundry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.