[AArch64][compiler-rt] Disable SME ABI routines if function multiversioning is not supported #94973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| #include "../cpu_model/aarch64.h" | |||
|
|
|||
| #if !defined(DISABLE_AARCH64_FMV) | |||
There was a problem hiding this comment.
I don't think you can just choose not to implement these specific routines, but still compile the rest. If the SME ABI routines require this feature, then we better make that dependency clear in cmake.
There was a problem hiding this comment.
I've added a warning to CMakeLists where we enable the SME ABI routines, though I can change this to an error if that would be more appropriate?
for building the AArch64 SME ABI routines.
kmclaughlin-arm
changed the title
sdesmalen-arm
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents build failures when building with
DISABLE_AARCH64_FMV,see #92921.