Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Layouts , Addition of new files #1000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sakshi-2797
Copy link

This contribution includes an alternate cpp implementation of the "optimize_layout_euclidean" function in layouts.py. The changes includes a faster cpp implementation of the optimization function by introducing separate files - umap_extend.cpp, xsrandom.cpp,xsrandom.hpp.

@lmcinnes
Copy link
Owner

lmcinnes commented Aug 4, 2023

This looks like impressive work, but for my own sake I would like to keep this version of umap as a python only library (for ease of maintenance and packaging). I would encourage you to build this work into a fork that can be a package you maintain (fast_umap perhaps?). You could roll in your spectral improvements there as well, and other speedups as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants