Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): horizontal overflow in preview on mobile devices #36

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

blenderskool
Copy link
Contributor

There is a horizontal overflow in the preview section of some components on mobile screens. This PR fixes it.

I have re-checked all the component previews on desktops and mobile layouts and these changes work the best while retaining the same previews of components as before. The align prop of PreviewComponent also continues to work in the same way.

Comparison of before / after the changes:

mobile-overflow.mov

Copy link

changeset-bot bot commented Dec 20, 2023

⚠️ No Changeset found

Latest commit: 35f1b78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 20, 2023

@blenderskool is attempting to deploy a commit to the Lemon Squeezy Team on Vercel.

A member of the Team first needs to authorize it.

@blenderskool
Copy link
Contributor Author

@brankoconjic @gilbitron Sorry for the ping, but do let me know if any other changes are required here 🙃!

@brankoconjic brankoconjic self-requested a review December 22, 2023 00:27
Copy link
Collaborator

@brankoconjic brankoconjic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks good!

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wedges-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 0:31am

@brankoconjic brankoconjic merged commit 5a5a45e into lmsqueezy:main Dec 22, 2023
4 checks passed
@blenderskool blenderskool deleted the fix/mobile-previews branch December 22, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants