Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

578 improve analytical likelihood #585

Merged
merged 11 commits into from
Sep 27, 2024
Merged

578 improve analytical likelihood #585

merged 11 commits into from
Sep 27, 2024

Conversation

cpaniaguam
Copy link
Collaborator

@cpaniaguam cpaniaguam commented Sep 19, 2024 •
edited
Loading

  • Simplify operations in analytical.py
  • Leverage unicode for variables names such as π = np.pi and τ = 2 * π
  • Clean up tests/test_likelihoods_lba.py

@cpaniaguam cpaniaguam linked an issue Sep 19, 2024 that may be closed by this pull request
Try the Stan implementation of the DDM analytical likelihood #578
Closed
@cpaniaguam cpaniaguam force-pushed the 578-improve-analytical-likelihood branch from 4c9ec0a to 8cb5a17 Compare September 19, 2024 20:43
@cpaniaguam cpaniaguam force-pushed the 578-improve-analytical-likelihood branch from fe1703a to c9c590f Compare September 26, 2024 01:58
@cpaniaguam cpaniaguam marked this pull request as ready for review September 26, 2024 03:51
digicosmos86
digicosmos86 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@digicosmos86 digicosmos86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Carlos!

@cpaniaguam cpaniaguam merged commit fa12018 into main Sep 27, 2024
7 checks passed
@cpaniaguam cpaniaguam self-assigned this Sep 27, 2024
@cpaniaguam cpaniaguam added the enhancement New feature or request label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digicosmos86 digicosmos86 digicosmos86 approved these changes

@AlexanderFengler AlexanderFengler Awaiting requested review from AlexanderFengler

Assignees

@cpaniaguam cpaniaguam

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try the Stan implementation of the DDM analytical likelihood
2 participants
@cpaniaguam @digicosmos86