Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pymc dependency to version 5.19 #611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cpaniaguam
Copy link
Collaborator

This pull request includes updates to dependencies in the pyproject.toml file. Namely, it updates of the pymc dependency to a newer version.

Dependency updates:

  • pyproject.toml: Updated the pymc dependency from ">=5.16.2,<5.17.0" to "^5.19".

The goal is to ensure this version is compatible with hssm and further investigate #608.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@AlexanderFengler
Copy link
Collaborator

@cpaniaguam what's going on with the tests here? Running for over 3h :0

@cpaniaguam
Copy link
Collaborator Author

@cpaniaguam what's going on with the tests here? Running for over 3h :0

@AlexanderFengler there seems to be a problem with pymc v.5.19 and the environments with Python v.3.10/12. I can't get it to install properly in those environments locally and it seems like in ci gets hung up. @digicosmos86 any ideas?

@digicosmos86
Copy link
Collaborator

I don't think this is anything new. We did have tests that ran for this long with certain values. Looks like slice samplers are causing this problem. @AlexanderFengler any idea from the outputs?

@digicosmos86
Copy link
Collaborator

@cpaniaguam what do you mean you can't install PyMC 5.19 locally?

@cpaniaguam
Copy link
Collaborator Author

@cpaniaguam what do you mean you can't install PyMC 5.19 locally?

Oh sorry, I meant that I can't install hssm with pymc v5.19 in environments with Python 3.10/12 on my computer using WSL.

@AlexanderFengler
Copy link
Collaborator

@digicosmos86 will look at the outputs, but it's a bit weird. Not getting those problems on my PRs. (slow tests ~30min)

@digicosmos86
Copy link
Collaborator

@digicosmos86 will look at the outputs, but it's a bit weird. Not getting those problems on my PRs. (slow tests ~30min)

@AlexanderFengler Yeah checked with Carlos about it but it seems that some tests just consistently fail after only updating PyMC. That's why we are moving to uv which allows us to create environments with different python versions so we can test these things locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants