Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the previous Status to DISPUTE in dispute message for solvers #571

Merged
merged 4 commits into from
Aug 25, 2024

Conversation

jgosmus
Copy link
Contributor

@jgosmus jgosmus commented Aug 20, 2024

Added the message 'Status previous to dispute' in the dispute message that informs the solver about the order.

I added the message in all the languages, but in the ones I could not translate I left the message in english, please confirm if this is ok or I have to change something.

Fix #418

@grunch grunch requested a review from Catrya August 20, 2024 13:37
Copy link
Member

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine! No problem with the translation to other languages, I can fix it later

@jgosmus
Copy link
Contributor Author

jgosmus commented Aug 22, 2024

As far as I am concerned, is there anything I need to do to close and merge this PR?

Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thank you, please add a LN invoice to send you the payment 😃

@grunch grunch merged commit c3b3241 into lnp2pBot:main Aug 25, 2024
4 checks passed
@jgosmus
Copy link
Contributor Author

jgosmus commented Aug 25, 2024

Thanks!!

Here is the invoice

llnbc500u1pnvkgwgsp5v0eg4lg2gx542539ujwsgyxvmnhzt68m6xezhvh9s4s24v3z23nqpp563vrt4cxcvt5z5sz6gjqnhg3ycxlj5h35k3h4fl9ws3pgghdztzqhp5uwcvgs5clswpfxhm7nyfjmaeysn6us0yvjdexn9yjkv3k7zjhp2sxq9z0rgqcqpnrzjqf45ps9ulp96uf6gdzaxgwc2vs8wl476y5f2p7gjk4s40vm67gxtwrxz8uqq0fqqqqqqqqqqqqqqthqqjq9qxpqysgqszgsmrpgr2jczk99s3n0p5rhrvxcmzf4jxf9yankhrq4eefggqejgel0psvvcc2nue5u2tyfkckrr0gytzxnrgp3xuv24aa95x6pckgq9nlndg

@grunch
Copy link
Member

grunch commented Aug 25, 2024

Thanks!!

Here is the invoice

llnbc500u1pnvkgwgsp5v0eg4lg2gx542539ujwsgyxvmnhzt68m6xezhvh9s4s24v3z23nqpp563vrt4cxcvt5z5sz6gjqnhg3ycxlj5h35k3h4fl9ws3pgghdztzqhp5uwcvgs5clswpfxhm7nyfjmaeysn6us0yvjdexn9yjkv3k7zjhp2sxq9z0rgqcqpnrzjqf45ps9ulp96uf6gdzaxgwc2vs8wl476y5f2p7gjk4s40vm67gxtwrxz8uqq0fqqqqqqqqqqqqqqthqqjq9qxpqysgqszgsmrpgr2jczk99s3n0p5rhrvxcmzf4jxf9yankhrq4eefggqejgel0psvvcc2nue5u2tyfkckrr0gytzxnrgp3xuv24aa95x6pckgq9nlndg

Paid, preimage 231350af5b900e7a994fa89e83e6473edd97d2c2bd22e6ee7a34a1c54baf05aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the previous Status to DISPUTE in dispute message for solvers
3 participants