Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add changelog modal #4800

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

canisminor1990
Copy link
Member

@canisminor1990 canisminor1990 commented Nov 26, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

image

📝 补充信息 | Additional Information

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 5:58pm
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 5:58pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@lobehubbot
Copy link
Member

👍 @canisminor1990

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 🌠 Feature Request New feature or request | 特性与建议 label Nov 26, 2024
src/app/(main)/_layout/Desktop.tsx Outdated Show resolved Hide resolved

import { Locales } from '@/locales/resources';

const BASE_URL = 'https://raw.githubusercontent.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个会导致只有用户那边翻墙了才能看到 changelog,感觉这个请求逻辑应该要做一份到 server 去请求。走 edge 的 trpc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

头图也有这个问题

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那头图是不是应该走一道上传,转到r2里去?

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (832f0ce) to head (dbd0b90).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4800      +/-   ##
==========================================
+ Coverage   91.53%   96.21%   +4.67%     
==========================================
  Files         538       27     -511     
  Lines       37803     3962   -33841     
  Branches     2325      321    -2004     
==========================================
- Hits        34603     3812   -30791     
+ Misses       3200      150    -3050     
Flag Coverage Δ
app ?
server 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌠 Feature Request New feature or request | 特性与建议 size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants