Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial port not being closed properly #41

Closed
lobis opened this issue Aug 17, 2023 · 0 comments · Fixed by #42
Closed

Serial port not being closed properly #41

lobis opened this issue Aug 17, 2023 · 0 comments · Fixed by #42
Assignees
@lobis
Labels
enhancement New feature or request

Comments

@lobis
Copy link
Owner

lobis commented Aug 17, 2023

Currently the serial port is not being closed properly in some instances which can lead to errors (not enough permissions). We should use python context manager to handle this.
@lobis lobis added the enhancement New feature or request label Aug 17, 2023
@lobis lobis self-assigned this Aug 17, 2023
@lobis lobis linked a pull request Aug 17, 2023 that will close this issue
Use Python contexts to properly handle serial connection #42
Merged
@lobis lobis closed this as completed in #42 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lobis lobis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Python contexts to properly handle serial connection lobis/hvps
1 participant
@lobis