Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds acrobot example #1059

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Conversation

justinberi
Copy link

Adds an example for acrobot. See #1058

@justinberi
Copy link
Author

@cmastalli I guess Gepetto/example-robot-data#118 would have to be merged first.

Happy to incorporate any fixes of nomenclature.

Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to wait for the new release of example-robot-data.
Then, we need to update the version dependency here: https://github.com/loco-3d/crocoddyl/blob/devel/CMakeLists.txt#L70

examples/notebooks/acrobot_urdf.ipynb Show resolved Hide resolved
examples/notebooks/acrobot_urdf.ipynb Outdated Show resolved Hide resolved
@cmastalli
Copy link
Member

@nim65s -- I am not sure why gitlab-ci is failing. It seems it doesn't find the new version of example-robot-data.
Could you help me to merge this PR?

@nim65s
Copy link
Collaborator

nim65s commented May 9, 2022

It's failing because I'm late, and I don't have much time for now, but I'm trying to fix this

@cmastalli
Copy link
Member

It is ok. This PR is not high priority, but just let me know when it gets sort out ;)

@cmastalli cmastalli merged commit d656618 into loco-3d:devel Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants