Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync submodule cmake #1185

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Sync submodule cmake #1185

merged 1 commit into from
Nov 28, 2023

Conversation

jcarpent
Copy link
Member

After merging this PR, we can proceed to a new release to update conda accordingly.
@cmastalli Do you agree?

cmastalli
cmastalli approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree @jcarpent!
I will starting preparing a release soon.

@nim65s
Copy link
Collaborator

nim65s commented Nov 28, 2023

Just by curiosity, why would conda need a release here ?

@cmastalli cmastalli merged commit ec95f53 into loco-3d:devel Nov 28, 2023
10 checks passed
@jcarpent
Copy link
Member Author

For packaging issues on the CMake aspects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmastalli cmastalli cmastalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcarpent @nim65s @cmastalli