Fixed broken bench + updated ROS CI #1194
Conversation
cmastalli
force-pushed
the
topic/cmake-boxqp
branch
from
7a8ce9b
to
642c3c9
Compare
|
@wxmerkt -- do you know what is happening with ROS Noetic jobs? |
cmastalli
force-pushed
the
topic/cmake-boxqp
branch
2 times, most recently
from
2e2c716
to
7819d87
Compare
cmastalli
force-pushed
the
topic/cmake-boxqp
branch
from
7819d87
to
3237af5
Compare
cmastalli
force-pushed
the
topic/cmake-boxqp
branch
from
4d16dd6
to
07ee4ad
Compare
cmastalli
force-pushed
the
topic/cmake-boxqp
branch
from
07ee4ad
to
bcefb4b
Compare
cmastalli
changed the title
| @@ -29,20 +25,17 @@ jobs: | |||
| # target after completion of the regular test target. The output of this step does affect the output of the CI process. | |||
| # Note, this does not affect projects that do not have pure CMake projects in their upstream_ws. | |||
| BUILDER: catkin_tools | |||
| AFTER_RUN_TARGET_TEST: 'source /root/target_ws/install/setup.bash && cd /root/target_ws/build/crocoddyl && env && make test' | |||
There was a problem hiding this comment.
This together with the continue-on-failure will most likely deactivate running the tests at all due to the way the jrl-cmakemodules interact with catkin_tools. I didnt get to see the PR until now
There was a problem hiding this comment.
I noticed we were running twice the tests. This is the reason why I removed this.
I also defined fail-fast as False. It doesn't look like "continuous-on-error" is stopping running other jobs' tests. I will check carefully this again.
In any case, the noetic Python tests are failing. It looks like it cannot find the Python bindings. Do you have any idea of what is happening?
There was a problem hiding this comment.
Thank you for the detail - I can take a look next week - I assume something in the tooling changed so it's no longer picking things up the way it should
There was a problem hiding this comment.
Thanks @wxmerkt! As you might know this happening in Pinocchio
This PR fixes broken bench examples and update the ROS CI jobs.