fix: minor ui improvements

loft-sh · Sep 3, 2020 · 1088f90 · 1088f90
1 parent 182cf48
commit 1088f90
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/chart/templates/deployment.yaml b/chart/templates/deployment.yaml
@@ -29,7 +29,8 @@ spec:
         {{- else }}
         image: "loftsh/loft:{{ .Chart.Version }}"
         {{- end }}
-        {{- if and .Values.livenessProbe .Values.livenessProbe.enabled }}
+        {{- if .Values.livenessProbe }}
+        {{- if .Values.livenessProbe.enabled }}
         livenessProbe:
           httpGet:
             path: /version
@@ -41,7 +42,9 @@ spec:
           initialDelaySeconds: 5
           periodSeconds: 10
         {{- end }}
-        {{- if and .Values.readinessProbe .Values.readinessProbe.enabled }}
+        {{- end }}
+        {{- if .Values.readinessProbe }}
+        {{- if .Values.readinessProbe.enabled }}
         readinessProbe:
           httpGet:
             path: /version
@@ -53,6 +56,7 @@ spec:
           initialDelaySeconds: 5
           periodSeconds: 10
         {{- end }}
+        {{- end }}
         env:
         {{- if not .Values.apiService.enabled }}
         - name: APISERVICE_DISABLED

diff --git a/chart/templates/serviceaccount.yaml b/chart/templates/serviceaccount.yaml
@@ -9,4 +9,8 @@ metadata:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
+{{- if .Values.dev }}
+imagePullSecrets:
+- name: devspace-auth-docker-pkg-github-com
+{{- end }}
 {{- end }}