Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs link for telemetry section #1509

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

neogopher
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #1498

@neogopher neogopher requested a review from FabianKramm February 1, 2024 16:15
Copy link
Contributor

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the links in the cobra command descriptions of the commands located in the cmd/vclusterctl/cmd/telemetry folder?

@neogopher
Copy link
Contributor Author

Could you please change the links in the cobra command descriptions of the commands located in the cmd/vclusterctl/cmd/telemetry folder?

Hi @ThomasK33 . Have already done that or am I missing something.

@ThomasK33
Copy link
Contributor

I'm blind. I mistook the file endings as md.😅

@ThomasK33 ThomasK33 merged commit 665047e into loft-sh:main Feb 1, 2024
60 checks passed
@neogopher
Copy link
Contributor Author

No worries. I understand. I myself had to recheck after I had pushed the changes to the PR, because all the changes look exactly the same and it all fits together in one screen. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in output of vcluster telemetry --help
2 participants