Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update k8s versions in version maps and default version #2213

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

rohantmp
Copy link
Contributor

@rohantmp rohantmp commented Oct 9, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind enhancement
/kind feature
/kind documentation
/kind test

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)

resolves ENG-4861

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...

What else do we need to know?

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d339d45
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/670d019a0aaa8900084330c2

@rohantmp
Copy link
Contributor Author

rohantmp commented Oct 9, 2024

Working on the conformance tests too. Can add it to this PR if necessary

@FabianKramm
Copy link
Member

@rohantmp you will need to update the templates as well as they currently have the version hardcoded

@rohantmp rohantmp marked this pull request as draft October 9, 2024 12:55
@rohantmp
Copy link
Contributor Author

rohantmp commented Oct 9, 2024

Apologies, meant to open this as draft for now

@rohantmp
Copy link
Contributor Author

you will need to update the templates as well as they currently have the version hardcoded

Ah, I see what you meant. Thanks :)

@rohantmp rohantmp force-pushed the bump31 branch 3 times, most recently from b751156 to c9db79f Compare October 11, 2024 01:53
@rohantmp
Copy link
Contributor Author

rohantmp commented Oct 11, 2024

k0s has an out-of-band patch release v1.31.1-k0s.1 Seeing if that works

@rohantmp rohantmp force-pushed the bump31 branch 7 times, most recently from 5ab863c to 34bf427 Compare October 14, 2024 10:43
@rohantmp rohantmp marked this pull request as ready for review October 14, 2024 12:17
@rohantmp
Copy link
Contributor Author

k0s default version not being bumped as discussed since the latest version breaks

@FabianKramm FabianKramm merged commit a3f78c4 into loft-sh:main Oct 14, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants