fix(cli): add --force-remove-finalizers to platform destroy #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
rohantmp
force-pushed
the
destroyCommand
branch
from
fa8d0fc to
4cd62a0
Compare
rmweir
requested changes
Dec 5, 2024
rmweir
requested changes
Dec 6, 2024
|
With changes:
|
cbron
reviewed
Dec 6, 2024
Signed-off-by: Rohan CJ <[email protected]>
Signed-off-by: Rohan CJ <[email protected]>
rohantmp
force-pushed
the
destroyCommand
branch
from
d429d1e to
9935811
Compare
rmweir
requested changes
Dec 11, 2024
rmweir
requested changes
Dec 11, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
2 similar comments
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5245
resolves ENG-5264
Please provide a short message that should be published in the vcluster release notes
What else do we need to know?
Adds prompt for this flag, also changes logging to mention that externally deployed vclusters are not cleaned up.