bugfix: set labels to kubeconfig and cert secrets #2330
+26
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
requested changes
Dec 18, 2024
pkg/util/kubeconfig/kubeconfig.go
Outdated
| @@ -70,6 +73,10 @@ func WriteKubeConfig(ctx context.Context, currentNamespaceClient client.Client, | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: secretName, | |||
| Namespace: secretNamespace, | |||
| Labels: map[string]string{ | |||
| KubeConfigSecretLabelAppKey: KubeConfigSecretLabelAppValue, | |||
| KubeConfigSecretLabelReleaseKey: secretNamespace, | |||
There was a problem hiding this comment.
I don't think the release name is equal to the namespace name, that only happens for development where the release is equal the namespace
There was a problem hiding this comment.
Hi @FabianKramm, I have made the necessary changes. I initially wanted to use 'vcluster.loft.sh/vcluster-name' instead of 'vcluster-name' as the key, but found the same key used as an annotation in syncer.go
pkg/certs/ensure.go
Outdated
| @@ -131,6 +137,10 @@ func EnsureCerts( | |||
| Name: secretName, | |||
| Namespace: currentNamespace, | |||
| OwnerReferences: ownerRef, | |||
| Labels: map[string]string{ | |||
| CertSecretLabelAppKey: CertSecretLabelAppValue, | |||
| CertSecretLabelReleaseKey: currentNamespace, | |||
There was a problem hiding this comment.
I don't think the release name is equal to the namespace name, that only happens for development where the release is equal the namespace
There was a problem hiding this comment.
I have made the necessary changes.
maheshbaliga
force-pushed
the
add-secret-labels
branch
from
bdf3abb to
dbf9d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2283 .The pull request adds labels to two secrets that contain a kubeconfig and a certificate. These labels help improve the organization and management of the secrets.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster 2 secrets containing a kubeconfig and a certificate were missing labels.
What else do we need to know?