fix: avoid unnecessary proxy container creation for already connected vCluster #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vCluster Signed-off-by: Rokibul Hasan <[email protected]>
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
requested changes
Dec 18, 2024
…ster Signed-off-by: Rokibul Hasan <[email protected]>
FabianKramm
requested changes
Dec 18, 2024
Signed-off-by: Rokibul Hasan <[email protected]>
FabianKramm
requested changes
Dec 19, 2024
Signed-off-by: Rokibul Hasan <[email protected]>
RokibulHasan7
force-pushed
the
connect-fix
branch
from
41ce239 to
3ff03c9
Compare
FabianKramm
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?
This PR adds a check to prevent the creation of a background proxy container when already connected to the specified vCluster. For example, if the command
vcluster connect vcluster-testis run while already connected tovcluster-test, the unnecessary proxy container will no longer be created.