Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection parameters - second step #556

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Collection parameters - second step #556

merged 4 commits into from
Mar 28, 2024

Conversation

benoitdevos
Copy link
Contributor

Companion of #551
Companion of logion-network/logion-backend-ts#296

  • Collection Parameters are now submitted at request time.
  • Collection request is done in a separate screen (instead of a dialog)
  • Home page is adapted to open different types of LOC (previously: different templates)
  • A few refactoring.

logion-network/logion-internal#1179

@benoitdevos benoitdevos requested a review from gdethier March 27, 2024 16:51
gdethier
gdethier approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@benoitdevos benoitdevos merged commit 828edf6 into main Mar 28, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/collection-params branch March 28, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier