Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage secrets #571

Merged
merged 3 commits into from
May 16, 2024
Merged

Manage secrets #571

merged 3 commits into from
May 16, 2024

Conversation

benoitdevos
Copy link
Contributor

Companion of

Allow user to manage secrets (add/remove/list) from his/her closed ID LOC.
Provide a new component (ViewableSecret) acting like a password field - i.e. the value is hidden by default, shown on demand.

logion-network/logion-internal#1253

Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I guess you did not use the bootstrap glyphs because it was not possible to use them in CSS-only mode?

src/loc/secrets/RemoveSecretDialog.tsx Outdated Show resolved Hide resolved
@benoitdevos benoitdevos merged commit e8f02c9 into main May 16, 2024
1 check passed
@benoitdevos benoitdevos deleted the feature/manage-secrets branch May 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants