Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "charge submitter" checkbox #578

Merged
merged 1 commit into from
May 30, 2024
Merged

Add "charge submitter" checkbox #578

merged 1 commit into from
May 30, 2024

Conversation

gdethier
Copy link
Contributor

  • Adds checkbox to "Add tokens record" dialog
  • Beware the hack to make things compile despite the react-hook-form controlled react-bootstrap control
  • Fix form validation (errors where not shown)

logion-network/logion-internal#1281

@gdethier gdethier requested a review from benoitdevos May 30, 2024 12:37
benoitdevos
benoitdevos approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@gdethier gdethier merged commit e24f70b into main May 30, 2024
2 checks passed
@gdethier gdethier deleted the feature/charge-tokens-record-submitter branch May 30, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos