Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.0 improvments #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wiibaa
Copy link
Contributor

@wiibaa wiibaa commented May 25, 2016

  • Improve error handling of xml/xpath parsing
  • Minor improvments (see changelog)
  • refactor the test file to
    • reuse xml parsing tests
    • group tests logically (I was lost, must admits)

Here is the nex structure of test contexts:

philippe@debian:~/dev/wiibaa/logstash-filter-xml$ grep context spec/filters/xml_spec.rb 
  context "ensure xml parsers consistent report of _xmlparsefailure" do
    context "XMLSimple validation" do
    context "Nokogiri validation" do
  context "parse standard xml" do
    context "using formatting options" do
      context "forcing_array" do
      context "suppress_empty" do
      context "force_content" do
  context "executing xpath query on the xml content and storing result in a field" do
    context "standard usage" do
    context "xpath expression configuration" do
    context "namespace handling" do
  context "plugin registration checks" do

@wiibaa
Copy link
Contributor Author

wiibaa commented May 25, 2016

@suyograo do you want to continue cleaning up this plugin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants