Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bucket_prefix option to limit lists to specific directory #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jalonsoa
Copy link

Release notes

What does this PR do?

Add a new parameter to allow select the directory to list inside the bucket.

Why is it important/What is the impact to the user?

If you have a bucket with different files from different proyects and you only want files from one directory you can only filter with exclude_options. If the bucket have many files you get the full file list each iteration. This can cause a waste of resources (bandwidth, for example).

If we add this prefix option, you get only the file list on your directory and not the complete list of files on the bucket.

Checklist

  • [X ] My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

How to test this PR locally

Related issues

Use cases

If you share the bucket with another applications or you need get files only on specific sub directory.

Screenshots

Logs

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 20, 2021

💚 CLA has been signed

@jalonsoa
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant