Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ddb billing mode in additional_settings #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c4pQ
Copy link

@c4pQ c4pQ commented Jan 30, 2023

[enhancement]

Release notes

  • Support DynamoDB BillingMode propagation from Ruby to Java.
  • Bump KCL version to 1.14.3

What does this PR do?

It allows to set DynamoDB BillingMode from pipeline yaml config's additional_settings map.
As BillingMode in Java can not be casted from String or Int to BillingMode on the fly we have to cast it manually before passing from Ruby to Java.

input {
  kinesis {
    application_name => "kinesis_application_kcl"
    kinesis_stream_name => "test"
    codec => json_lines
    profile => "default"
    additional_settings => {
      billing_mode => "PAY_PER_REQUEST"
    }
  }
}
output {
    stdout{codec => rubydebug}
}

Why is it important/What is the impact to the user?

This PR gives an opportunity to tune one additional setting of Kinesis Client and avoid erroneous behavior.

Behavior before changes:

[ERROR] 2023-01-09 07:31:49.865 [[main]-pipeline-manager] javapipeline - Pipeline error {:pipeline_id=>"main", :exception=>#<TypeError: cannot convert instance of class org.jruby.RubyString to class com.amazonaws.services.dynamodbv2.model.BillingMode>...

KCL version's bump keeps plugin updated.

Checklist

  • [+] My code follows the style guidelines of this project
  • [+] I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • [-] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [-] I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 30, 2023

💚 CLA has been signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant