Sequel datetime class consistency #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests SUCCEED when run on their own, but FAIL when run after any instance of a plugin has been initialized with `jdbc_default_timezone`, since doing so globally configures Sequel to use DateTime instead of Time: To validate, modify the `.ci/run.sh` execution line to be: > ~~~ > bundle exec rspec spec --format documentation --example "without jdbc_default_timezone" > ~~~
By default, when a plugin is configured _without_ `jdbc_default_timezone` timestamps are assumed to be in the same timezone as the Logstash host machine, because they are parsed with Ruby's `Time#parse` which uses local context. However, when any one plugin declares `jdbc_default_timezone`, we load Sequel's `named_timezones` extension, which has a side-effect of globally changing `Sequel.datetime_class` to ruby's `DateTime`. The plugins that are configured with `jdbc_default_timezone` have enough information to apply the separately-provided offset, but the plugins that do _not_ have a `jdbc_default_timezone` directive become broken and effectively fail to parse the timestamps as they did when run on their own. Sequel's `named_timezones` extension supports being used with `Time` objects, and is noted to override `Sequel#datetime_class` on load only for historic reasons. We force Sequel to use ruby's `Time` class globally (enforcing its default and preventing it from being changed). This is done inside of a separately-required bootstrap, which allows us to ensure it is loaded exacltly once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a bug in which any one instance of a JDBC input plugin using
jdbc_default_timezonechanges the behaviour of plugin instances that do not usejdbc_default_timezone, by:named_timezonesextension, andSequel#datetime_classfrom being anything other than its original default value.This PR has two commits:
Resolves: #150
Relates: #53
Relat3es: #107