[Doc] clarified the usage of and settings #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Clarified the usage of
jdbc_validation_timeout
andconnection_retry_attempts_wait_time
settings.What does this PR do?
Improve the documentation description of a couple of configs.
The
connection_retry_attempts_wait_time
is used as retry mechanism only at Sequel Database object creation, so at connection pool time creation, during the registration of the plugin.The
jdbc_validation_timeout
is used by Sequel to decide to validate or not a connection when it's borrowed from the pool. If the connection hasn't received or sent data for more than this timeout then a "ping query" is executed; but it doesn't actively executes the ping queries when the connections are in the pool, just on the borrow action.connection_retry_attempts_wait_time
is usedjdbc_validation_timeout
is used in Sequel.Why is it important/What is the impact to the user?
Avoid to set not aligned expectations on the usage of these settings.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature works