Fix jdbc_fetch_size with postgresql #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmax
force-pushed
the
fix_postgressql_fetching
branch
from
1798e97 to
39cfce3
Compare
robbavey
reviewed
May 5, 2020
| @@ -1076,7 +1075,7 @@ | |||
| end | |||
|
|
|||
| it "should report the statements to logging" do | |||
| expect(plugin.logger).to receive(:debug).once | |||
| expect(plugin.logger).to receive(:debug).thrice | |||
There was a problem hiding this comment.
Do we know why this needed to change?
| paged_dataset.each do |row| | ||
| # Execute query in transaction cause PG driver require autocommit off for set fetch count | ||
| # See: https://jdbc.postgresql.org/documentation/head/query.html | ||
| db.transaction(rollback: :always) do |
There was a problem hiding this comment.
I wonder if it might be possible to potentially use paged_each here?
If not, do we need to use transactions when paging is not enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from old library to new: logstash-plugins/logstash-input-jdbc#368
According to documentation (https://jdbc.postgresql.org/documentation/head/query.html) we need autocommit disabled. Work around is to create transaction and rollback always.