Replace document_already_exist_exception with version_conflict_engine_exception in the silence_errors_in_log setting example #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent_already_exists_exception with version_conflict_engine_exception
|
💚 CLA has been signed |
|
@logstashmachine bump patch |
|
The changes look good. Please bump the version to |
kaisecheng
approved these changes
Nov 9, 2023
BBQigniter
added a commit
to BBQigniter/logstash-docs
that referenced
this pull request
Nov 21, 2023
The example is unfortunately deprecated and does not work anymore. See logstash-plugins/logstash-output-elasticsearch#1159 Also it would be nice to have a list of possible values somewhere - I could not find any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example reported in documentation for the setting
silence_errors_in_logdoes not appear to work with modern version of Elasticsearch. The correct value should beversion_conflict_engine_exception, which as per https://github.com/elastic/elasticsearch/blob/main/server/src/main/java/org/elasticsearch/ElasticsearchException.java#L1271C1-L1272C replaced the exceptiondocument_already_exist_exception.This PR replace in the example for silence_errors_in_log the deprecated/not more existent
document_already_exist_exceptionwith the valueversion_conflict_engine_exception.