refactor travis tests for the new release cadence #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
reviewed
Nov 14, 2024
Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
This looks good. The only other thing i could think of is incorporating https://github.com/logstash-plugins/.ci/pull/66/files in to the docker-setup.sh change to help keep those files somewhat consistent. I would be happy to do that as a follow up PR though to focus on unblocking CI now.
|
++ @donoghuc please open a follow up PR. I think we can also refactor the source docker-setup to accomodate plugins with extra containers, but it's out of scope here for this effort. |
donoghuc
added a commit
to donoghuc/logstash-filter-elasticsearch
that referenced
this pull request
Nov 22, 2024
This commit ports the changes from logstash-plugins/logstash-output-elasticsearch#1192 to the `docker-setup.sh` script as a starting point. Additionally it updates the travis configuration to mirror the changes in the `output` plugin.
|
Follow up PR #1193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.