Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add example Env var usage for hosts setting #992

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

roaksoax
Copy link
Contributor

@roaksoax roaksoax commented Feb 16, 2021

Adds an example under hosts setting showing users how to use an environment variable with multiple white-space delimited hosts.

Fixes elastic/logstash#12661

Adds an example under hosts setting showing users how to use an environment variable with multiple white-space delimited hosts.
@roaksoax roaksoax changed the title Add example under hosts setting [Doc] Add example Env var usage for hosts setting Feb 16, 2021
@roaksoax roaksoax requested a review from karenzone February 16, 2021 15:33
docs/index.asciidoc Outdated Show resolved Hide resolved
@roaksoax roaksoax requested a review from robbavey February 16, 2021 19:17
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos, and some content queries

docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this helpful example. It definitely makes the docs better. I left some suggested text inline. Note that I removed the link to the concept page. Instead, I lifted the critical part of the text and included it here.

docs/index.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion based on what we discussed above.

docs/index.asciidoc Outdated Show resolved Hide resolved
@roaksoax roaksoax self-assigned this Sep 26, 2022
Co-authored-by: Karen Metts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] Unclear docs on supporting multiple hosts in an environment variable.
3 participants