Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs, the example for high volume is
But the docs say the max
message_count_threshold
is 1000. (https://github.com/googleapis/google-cloud-java/blob/dc2672ad1838a8d15a66e1f1697c97c84e4e0933/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L113). So let's fix this example.Also,
5MB
isn't a valid value andrequest_byte_threshold
expects an integer. So, fix this in the example as well as the docs where it shows the default. (I made the mistake of keeping the underscores in the integer since it's valid in Ruby).This should also address #16