Some initial tests #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been starting to work on the opentsdb output on things unrelated to this change, but felt that some tests would be nice to ensure that I don't break something. This adds some very basic tests just to make sure that the plugin writes what we expect to opentsdb.
I stole
Mocks::Serverand a few ideas from logstash-output-graphite for this, since it makes it super simple to make sure we write what we expect to the server. It's just testing successful cases though. I'll try to add some tests for exception handling in the future.I know the tests are quite simple, but please let me know what you think! Thanks.
EDIT: Added a test to ensure the plugin tries to reconnect if the connection is reset.