Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change codec instance comparison #69

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Aug 23, 2023

Switch from instanceof to string comparision to check the type of codec during regitration


Part of elastic/logstash#15236

@andsel andsel self-assigned this Aug 23, 2023
@jsvd
Copy link
Member

jsvd commented Sep 8, 2023

@logstashmachine bump patch

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 906c1a8 into logstash-plugins:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing to logstash-output-syslog and status of the plugin?
3 participants