Add extra context for error reporter #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
requested review from
CarlosGamero,
drdaemos and
a team
as code owners
ilya-levin-lokalise
approved these changes
Sep 9, 2024
kibertoad
commented
Sep 9, 2024
|
|
||
| const responseAfter = await getMetrics() | ||
| const responseAfter = await vi.waitUntil( |
There was a problem hiding this comment.
changes unrelated to the PR, but for whatever reason test is failing due to data generation taking longer than before. I assume GA is being slow.
locally it was passing without any changes
There was a problem hiding this comment.
Mmm so it was still failing 😓, I included the waitForJob as I thought the delay was caused by the processor and not by the metrics, good to see you fixed it, thanks Igor 🙌
CarlosGamero
approved these changes
Sep 9, 2024
…o feat/error-reporter-context
CarlosGamero
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
call to errorReporter now include request params
Checklist
major,minor,patchorskip-release