Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types #26

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Improve types #26

merged 1 commit into from
Jul 8, 2024

Conversation

kibertoad
Copy link
Collaborator

Changes

Improves narrowing down of types, they are no longer assumed to be null when we already know that receiving empty content will throw an error.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@kibertoad kibertoad added the minor label Jul 8, 2024
@kibertoad kibertoad requested a review from CarlosGamero July 8, 2024 17:13
CarlosGamero
CarlosGamero approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@CarlosGamero CarlosGamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🚀

@kibertoad kibertoad merged commit ce8ef63 into main Jul 8, 2024
6 checks passed
@kibertoad kibertoad deleted the feat/better-types branch July 8, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosGamero CarlosGamero CarlosGamero approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibertoad @CarlosGamero