Fixes and introduction of additional variables #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ducane
changed the title
|
Added functionality for switching java versions with fzf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked through your dotfiles project and i am impressed. Nice work!
I tried to make it a bit easier for other developers to get into the project. The main change were to introduce USER_PATH and DOTFILES_PATH variables which allow the developer to circumvent the absolute paths.
Also i changed the brew installs since
brew cask installis deprecated and replaced bybrew install --cask.I also updated the
brew-install.shscript, since, as far as i could find out, thebrew searchcommand is now expecting an argument.Further questions that came up during my refactorings:
1. If i run
manon any command i don't get the full man page, as i'm used to. In the cases i tests, only the examples are returned. Is this a wanted setting, and if yes, where can i change it?2.
brew-cask.shis using fzf-tmux. I couldn't really fix this similarly tobrew-install.shsince i didn't knew how it should exactly work. Could you maybe describe how it worked previously, or what the expected functionality is?3. The
settings.zshis trying to execute az.luafile which isn't included in the project. Is there a reason for this?