This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
Alter to support config project as the "final" code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite-config_spreedly.git into dev-andy-crutchfield-f9ff
…n details explore and move dashboards to new world and compare/contrast
move things in from core project
…ite-config_spreedly.git into dev-alonso-narro-5dm6
…ite-config_spreedly.git into dev-kip-uhlhorn-gjxz
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swhitey I have confirmed this code works in the spreedly looker hosted instance. Matches all results from the current production marketplace product. Only difference is that the "final" project, the one that actually hosts in use models and dashboards, is now the project which the customer has the ability to change (the "config" project.
Look for corresponding PR in related core repo.
Note the added name -spreedly to both model files, and spreedly specific connection name which probably need to be altered before merging with production marketplace.
CC @DillonMorrison