Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Order-filter.md #10633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Order-filter.md #10633

wants to merge 1 commit into from

Conversation

zeekun
Copy link

@zeekun zeekun commented Aug 14, 2024

The example should use an array not string

order: ['price DESC'],

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

The example should use an array not string

order: ['price DESC'],

Signed-off-by: zeekun <[email protected]>
@@ -67,7 +67,7 @@ Return the three most expensive items, sorted by the `price` property:

```ts
await itemRepository.find({
order: 'price DESC',
order: ['price DESC'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeekun, it seems like either way is fine. If there are more than 1 properties, then we need to use array. See https://github.com/loopbackio/loopback-next/blob/master/docs/site/Order-filter.md?plain=1#L19-L27.
Or are you experiencing problems without the array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants