-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use FakeTTY only for CLI tests #8302
use FakeTTY only for CLI tests #8302
Conversation
PFX certificate doesn't seem to work on Node v17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change 👇
Should we disable the test for version v17? nodejs/node#40672 (comment) |
Nice find, @frbuceta! I wonder if we could fix the crux of the problem by updating the PFX artifact? |
They say that OpenSSL does not support it in its version v3 which is used by Node v17. Although update does not work. |
Signed-off-by: Francisco Buceta <[email protected]>
Tests cannot be seen when they fail due to Fake-TTY
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈