Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FakeTTY only for CLI tests #8302

Merged
merged 1 commit into from
May 23, 2022
Merged

use FakeTTY only for CLI tests #8302

merged 1 commit into from
May 23, 2022

Conversation

frbuceta
Copy link
Contributor

Tests cannot be seen when they fail due to Fake-TTY

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@frbuceta frbuceta self-assigned this Feb 11, 2022
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
@frbuceta
Copy link
Contributor Author

PFX certificate doesn't seem to work on Node v17

Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change 👇

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
@frbuceta frbuceta changed the title Remove FakeTTY and minimize CLI impact on tests use FakeTTY only for CLI tests Feb 18, 2022
@frbuceta
Copy link
Contributor Author

PFX certificate doesn't seem to work on Node v17

Should we disable the test for version v17? nodejs/node#40672 (comment)

@achrinza
Copy link
Member

Nice find, @frbuceta! I wonder if we could fix the crux of the problem by updating the PFX artifact?

@frbuceta
Copy link
Contributor Author

Nice find, @frbuceta! I wonder if we could fix the crux of the problem by updating the PFX artifact?

They say that OpenSSL does not support it in its version v3 which is used by Node v17. Although update does not work.

Signed-off-by: Francisco Buceta <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2374294555

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2164 unchanged lines in 167 files lost coverage.
  • Overall coverage decreased (-21.07%) to 55.392%

Files with Coverage Reduction New Missed Lines %
extensions/authentication-jwt/src/models/refresh-token.model.ts 1 75.0%
extensions/authentication-jwt/src/repositories/refresh-token.repository.ts 1 83.33%
extensions/authentication-jwt/src/services/jwt.service.ts 1 79.31%
extensions/socketio/src/booters/socketio.booter.ts 1 93.33%
extensions/socketio/src/providers/reject-method.provider.ts 1 66.67%
extensions/socketio/src/socketio-controller-factory.ts 1 90.7%
extensions/socketio/src/socketio.sequence.ts 1 91.67%
packages/authentication/src/decorators/authenticate.decorator.ts 1 86.11%
packages/authentication/src/types.ts 1 90.91%
packages/boot/src/booters/application-metadata.booter.ts 1 91.67%
Totals Coverage Status
Change from base Build 2374100723: -21.07%
Covered Lines: 9527
Relevant Lines: 12373

💛 - Coveralls

@frbuceta frbuceta merged commit 4e3c5ce into loopbackio:master May 23, 2022
@frbuceta frbuceta deleted the frbuceta/remove-action-fake branch May 23, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants