Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS file #342

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Update CODEOWNERS file #342

merged 1 commit into from
Nov 24, 2021

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Nov 22, 2021

Description

Add @achrinza as the maintainer of this connector. 🎉
Thank you @jannyHou for contributing to this repo in the past.

Update CODEOWNERS file to reflect current status.

Since npm@8 does not support Node.js 10.x, remove Node.js10 from CI.

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhmlau! Though I'd like to put the CI pipeline change in a separate PR.

@@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [10, 12, 14, 16]
node-version: [12, 14, 16]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do this in a separate PR? If the CI pipeline is only failing with v10, I think it should be safe to merge.

This would also be considered a breaking change. Since this package doesn't get much feature updates, it may be preferable to follow Module LTS Policy (i.e. to drop support for v10 when v16 reaches EOL).

For NPM compatibility, we may want to explicitly set the NPM version (i.e npm install --global npm@7 for our CI pipelines.

I'll prepare PRs to fix this issue across all of our existing CI pipelines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened loopbackio/cicd#6 to track this NPM version pinning issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. I've updated this PR only have the codeowners file change.

@dhmlau dhmlau merged commit e457361 into master Nov 24, 2021
@dhmlau dhmlau deleted the codeowner2 branch November 24, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants