-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS file #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dhmlau! Though I'd like to put the CI pipeline change in a separate PR.
@@ -19,7 +19,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest] | |||
node-version: [10, 12, 14, 16] | |||
node-version: [12, 14, 16] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do this in a separate PR? If the CI pipeline is only failing with v10, I think it should be safe to merge.
This would also be considered a breaking change. Since this package doesn't get much feature updates, it may be preferable to follow Module LTS Policy (i.e. to drop support for v10 when v16 reaches EOL).
For NPM compatibility, we may want to explicitly set the NPM version (i.e npm install --global npm@7
for our CI pipelines.
I'll prepare PRs to fix this issue across all of our existing CI pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened loopbackio/cicd#6 to track this NPM version pinning issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. I've updated this PR only have the codeowners file change.
Signed-off-by: Diana Lau <[email protected]>
Description
Add @achrinza as the maintainer of this connector. 🎉
Thank you @jannyHou for contributing to this repo in the past.
Update
CODEOWNERS
file to reflect current status.Since npm@8 does not support Node.js 10.x, remove Node.js10 from CI.
Checklist
guide