-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support additional parameter for optional date timezone #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scrib3r <[email protected]>
Signed-off-by: Scrib3r <[email protected]>
Signed-off-by: Scrib3r <[email protected]>
Signed-off-by: Scrib3r <[email protected]>
achrinza
approved these changes
Mar 1, 2023
Pull Request Test Coverage Report for Build 4313867057
💛 - Coveralls |
Signed-off-by: Scrib3r <[email protected]>
Signed-off-by: Scrib3r <[email protected]>
@achrinza |
dhmlau
approved these changes
Mar 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Scrib3r, thanks for the PR. Your PR LGTM. I've added @raymondfeng as reviewer per your request. |
raymondfeng
approved these changes
Mar 9, 2023
@Scrib3r, thanks again for your contribution. Your PR has been merged! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version of the library always puts the timezone symbol Z at every end of date despite that not all soap services support this date format.
I've extended the
options
parameter for passing the optionaldate.timezone
parameter toXmlHandler
and nested functions for using the optional timezone symbol.The next code is an example of disabling timezones in the date's string:
By default
enabled
value istrue
for avoiding breaking changes for the existing API.Related issues
Checklist
guide