Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate request package to needle #586

Closed
wants to merge 12 commits into from
Closed

Migrate request package to needle #586

wants to merge 12 commits into from

Conversation

thienanh96
Copy link

@thienanh96 thienanh96 commented Jul 3, 2023 •
edited
Loading

Description

Related issues

Notes:

I'm not sure if it works with ntlm which is using httpntlm-maa package. But can the tests cover it as well?

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@thienanh96 thienanh96 changed the title Anh features/migrate request to needle Migrate request package to needle Jul 3, 2023
@thienanh96 thienanh96 closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

@achrinza achrinza Awaiting requested review from achrinza achrinza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thienanh96