Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve CVE-2023-26136 #701

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: resolve CVE-2023-26136 #701

merged 1 commit into from
Feb 16, 2024

Conversation

toddtarsi
Copy link
Contributor

Description

Switch from request to @cypress/request so we have no CVE plz

Related issues

#632

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@toddtarsi
fix: resolve CVE-2023-26136
f0b95de 
do this by moving to a supported request variant

Signed-off-by: Todd Tarsi <[email protected]>
@toddtarsi toddtarsi mentioned this pull request Feb 16, 2024
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7932997177

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.657%
Totals Coverage Status
Change from base Build 7877406705: 0.0%
Covered Lines: 2892
Relevant Lines: 3247
💛 - Coveralls

@achrinza achrinza merged commit 63a5014 into loopbackio:master Feb 16, 2024
10 checks passed
@achrinza achrinza linked an issue Feb 16, 2024 that may be closed by this pull request
CVE-2023-26136 in tough-cookie #632
Closed
@dhmlau
Copy link
Member

dhmlau commented Feb 27, 2024

@toddtarsi, [email protected] is released that contains your change. Thanks!

@toddtarsi
Copy link
Contributor Author

@dhmlau - Oh my gosh, thank you so much!!! You are amazing!

@dhmlau dhmlau mentioned this pull request Apr 10, 2024
Closed
2 tasks
@s100 s100 mentioned this pull request Sep 20, 2024
Open
@s100
Copy link
Contributor

s100 commented Sep 20, 2024

Part of #328 and #535.

@s100 s100 mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrinza achrinza achrinza approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2023-26136 in tough-cookie
5 participants
@toddtarsi @coveralls @dhmlau @s100 @achrinza