Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to httpntlm and fix flaky test #717

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

toddtarsi
Copy link
Contributor

Description

Switches httpntlm-maa to the supported thing.
Fixed the test suite by repairing the bad async bits in the prior test to the reporting test.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@coveralls
Copy link

coveralls commented Mar 17, 2024

Pull Request Test Coverage Report for Build 8316466170

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 84.695%

Files with Coverage Reduction New Missed Lines %
src/http.js 1 93.02%
Totals Coverage Status
Change from base Build 8272050559: 0.04%
Covered Lines: 2893
Relevant Lines: 3247

💛 - Coveralls

@toddtarsi
Copy link
Contributor Author

@raymondfeng @achrinza - Would one of you be able to look at this PR sometime this week? It deals with a couple Soc-2 issues around request and tough-cookie I think.

@achrinza achrinza merged commit 50dd7ac into loopbackio:master Mar 20, 2024
10 checks passed
@achrinza
Copy link
Member

Thanks for the PR and test fixes! Your changes have been merged 🎉

@toddtarsi
Copy link
Contributor Author

Yay! Thank you @achrinza !

@dhmlau
Copy link
Member

dhmlau commented Mar 22, 2024

[email protected] is just released.

@toddtarsi
Copy link
Contributor Author

Woohoo! Thanks @dhmlau

@s100
Copy link
Contributor

s100 commented Sep 20, 2024

Part of #328 and #535.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants