-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to httpntlm and fix flaky test #717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Pull Request Test Coverage Report for Build 8316466170Details
💛 - Coveralls |
Signed-off-by: Todd Tarsi <[email protected]>
@raymondfeng @achrinza - Would one of you be able to look at this PR sometime this week? It deals with a couple Soc-2 issues around request and tough-cookie I think. |
achrinza
approved these changes
Mar 20, 2024
Thanks for the PR and test fixes! Your changes have been merged 🎉 |
Yay! Thank you @achrinza ! |
|
Woohoo! Thanks @dhmlau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches httpntlm-maa to the supported thing.
Fixed the test suite by repairing the bad async bits in the prior test to the reporting test.
Related issues
Checklist
guide