Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported GradientFilter from Cxx to Python #133

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FlorianFritz
Copy link

Plain port from Cxx to Python

iren.SetRenderWindow(renwin)
iren.Initialize()
iren.Start()
return 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This return statement is not needed.

@ajpmaclean
Copy link
Collaborator

Looks good. Here are some extra things you will need to do:

  1. In the file src/Python.md section (Working with 3D Data) you will need to add the following line in alphabetical order to:
[GradientFilter](/Python/PolyData/GradientFilter) | vtkGradientFilter | Compute the gradient of a scalar field on a data set.
  1. You will need to copy src/Testing/Baseline/Cxx/PolyData/TestGradientFilter.png to src/Testing/Baseline/Python/PolyData/

  2. Consider using vtkNamedColors to set the colors. See GeometricObjectsDemo for how to do this. In this case, use 84, 89, 109 as the rgb values.

Steps 1, 2 ensure that the code appears on the web page in the correct section with a nice picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants