Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

St table should add pagination by initial state #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omershelef
Copy link

The problem: in case we want to paginate the data in the smart table, st-pagination must be loaded and call the slice function in the stTableController. because st-pagination depends on templateUrl to run its link function it's sometimes may take time for it to load, in this case the smart table can be loaded into the DOM before the link function of stPagination had time to run. loading all smart table into the DOM without any pagination will cause the browser to stuck in case there is too much data

by initial the pagination number to itemsByPage value, we make sure the data will be loaded always with initial pagination state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant