Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
find in
bench_test.go: BenchmarkGet
db.Close()
holddb.mu
and closeflushChan
.At the same time, the
listenMemtableFlush -> db.flushMemtable
may trying holddb.mu
to flush memtable.listenMemtableFlush
blocked, it cannot send msg tocloseChan
, anddb.Close()
blocked in<-db.closeChan
.Solve
close
flushChan
withoutdb.mu
.