Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for Helix editor #2011

Open
wants to merge 1,731 commits into
base: status
Choose a base branch
from
Open

Adds support for Helix editor #2011

wants to merge 1,731 commits into from

Conversation

xtrasmal
Copy link

@xtrasmal xtrasmal commented Apr 6, 2024 •
edited
Loading

All submissions

Adding/updating Application X Support

  • This PR is only for one application
  • It has been added to the list of supported applications in the README
  • Changes have been added to the WIP section of the CHANGELOG
  • Syncing does not break the application
  • Syncing does not compete with any syncing functionality internal to the application
  • The configuration syncs the minimal set of data
  • No file specific to the local workstation is synced
  • No sensitive data is synced

Improving the Mackup codebase

  • My submission passes the tests
  • I have linted the code locally prior to submission
  • I have written new tests as applicable
  • I have added an explanation of what the changes do

ameyuuno and others added 30 commits September 16, 2020 14:15
@ameyuuno
Merge branch 'master' into feature/fix-poetry-config-backup
38dec81
@tareksamni @lra
Add support for K9s and p10k (lra#1636)
f5ee2fe 
* Add support for K9s and p10k

* Sort in Readme.md

* Update p10k.cfg

Co-authored-by: Laurent Raufaste <[email protected]>
@ameyuuno
Merge branch 'master' into feature/fix-poetry-config-backup
c6ab501
@ameyuuno
add support pycharm 2020.(2, 3, 4)
9d70f2f 
squash commits because of lra#1629 (review)
@dfang
Add draft support (lra#1614)
e71c129 
* Add draft support

https://draft.sh/

* Update readme and changelog
feat: new app npmrc
750fad3
added support for Visual Studior for Mac version 8
ab53a10
@janniks
Add raycast
613bef3
@kidonng
Add support for zoxide
5f1e286
@kidonng
Update CHANGELOG
8285a74
@pwae
add additional file to little snitch configuration (lra#1672)
11723e9
@lra
Remove support for Oh My Zsh (lra#1674)
19e26f0 
Fix lra#1384
@hongqn @lra
fix: aria2 supports XDG_CONFIG_HOME (lra#1671)
30c4e5f 
Quote from [aria2 documentation](https://aria2.github.io/manual/en/html/aria2c.html#aria2-conf):

> By default, aria2 checks whether the legacy path
> `$HOME/.aria2/aria2.conf` is present, otherwise it parses
> `$XDG_CONFIG_HOME/aria2/aria2.conf` as its configuration file.

Co-authored-by: Laurent Raufaste <[email protected]>
@lra @ben-509
Scooby config/intellij (lra#1675)
482e195 
* Add config files for IntelliJ IDEA.

* Add support for IntelliJ Ultimate Edition 2017.1

Co-authored-by: Ben Samuel <[email protected]>
@lra
Merge branch 'patch-3' of https://github.com/kidonng/mackup into kido…
459d719 
…nng-patch-3
@lra
Merge branch 'kidonng-patch-3'
c5061cb
@lra
Clarify app name usage
e82a260 
Fix lra#1670
@lra
Fix CI
b124b90
@visika @lra
Support espanso on Linux (lra#1665)
21550fe 
https://espanso.org/docs/get-started/#configuration

Co-authored-by: Laurent Raufaste <[email protected]>
@lra
Merge branch 'master' into master
4944da4
@lra
Update README and CHANGELOG
7cd0d43
@lra
Merge branch 'janniks-master'
ad4a890
@lra
Merge branch 'master' into feature/add-support-pycharm2020
44603ab
@lra
sort lines
7e107c1
@lra
Merge branch 'ameyuuno-feature/add-support-pycharm2020'
af78179
@joshmedeski @lra
Add lazygit support (lra#1651)
685569e 
Co-authored-by: Laurent Raufaste <[email protected]>
@joshmedeski @lra
Add lf application (Terminal file manager) (lra#1650)
cd86c2c 
* Add lf application (Terminal file manager)

* Remove extra text from changelog

Co-authored-by: Laurent Raufaste <[email protected]>
@lra
Mackup 0.8.30
09b6bfe
@lra
Merge branch 'master' of github.com:lra/mackup
9d69720
@lra
Order and remove webstorm entries
6fb31cf 
Fix lra#1628
lra and others added 18 commits January 15, 2024 20:35
@lra
Remove nose test on 2.7
6629dae
@lra
Black formatting (lra#1992)
3775c54
@LarsRefsgaard
Add Aerospace as an application (lra#1990)
eecbffc
@LarsRefsgaard @lra
Add support for JankyBorders (lra#1991)
2464f9a 
Co-authored-by: Laurent Raufaste <[email protected]>
@lra
Add MacOS 14 (lra#1993)
79cfdc4
@LarsRefsgaard @lra
Add support for SketchyBar (lra#1995)
4a096f7 
Co-authored-by: Laurent Raufaste <[email protected]>
@lra
Update poetry.lock
7509dfd
@lra
Merge branch 'master' of github.com:lra/mackup
5f88252
@lra
Replace black with ruff (lra#1996)
3e4943b
@lra
Enable tests on 3.12 (lra#1997)
e9dfd10
@lra
Update test.yaml (lra#1998)
9666a57
@lra
Bunch of cleanups (lra#1999)
ca38f2a
@Wxh16144
feat: Add support for nvm (lra#2001)
5dafbc7
@damosse31
Add support for PHPStorm 2023.3 (lra#2002)
77e8112
@xtrasmal
Create helix.cfg
ed4e472 
Adds support for Helix editor.
https://helix-editor.com/
@xtrasmal
adds Helix to CHANGELOG.md
1242f3e
@xtrasmal
adds Helix to README.md
1d26002
@xtrasmal
Merge pull request #1 from xtrasmal/xtrasmal-patch-1
cd2bb5f 
Added support for Helix editor. 
- syncs .config/helix/config.toml
- syncs .config/helix/languages.toml
@xtrasmal
Copy link
Author

xtrasmal commented Apr 6, 2024

Helix editor
https://helix-editor.com/

krueschi
krueschi suggested changes Jul 23, 2024
View reviewed changes
Copy link

@krueschi krueschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as helix is a command line editor I suggest writing the name with a lower "h" (not capitalized "H") in all appearances.

@xtrasmal
Copy link
Author

Hi there,

Does it matter in any way that the command itself is invoked by calling 'hx'?

@krueschi
Copy link

Hi there,

Does it matter in any way that the command itself is invoked by calling 'hx'?

I don't think so but for consistency lower case for terminal apps seems reasonable.

@xtrasmal xtrasmal changed the base branch from master to status July 25, 2024 15:04
@xtrasmal
Update helix.cfg
a1c3136 
Changes name to lowercase
@xtrasmal
Copy link
Author

@krueschi done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krueschi krueschi krueschi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.