Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant scripts.cfg #2015

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

martimlobao
Copy link

@martimlobao martimlobao commented Apr 15, 2024

Already exists as part of macosx.cfg

All submissions

Adding/updating Application X Support

  • This PR is only for one application
  • It has been added to the list of supported applications in the README
  • Changes have been added to the WIP section of the CHANGELOG
  • Syncing does not break the application
  • Syncing does not compete with any syncing functionality internal to the application
  • The configuration syncs the minimal set of data
  • No file specific to the local workstation is synced
  • No sensitive data is synced

Improving the Mackup codebase

  • My submission passes the tests
  • I have linted the code locally prior to submission
  • I have written new tests as applicable
  • I have added an explanation of what the changes do

Already exists in scripts.cfg
Copy link
Owner

@lra lra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.
Can you delete scripts.cfg instead?
I don't know why it exists by itself.

@martimlobao martimlobao changed the title remove redundant Library/Scripts from macosx remove redundant scripts.cfg Apr 18, 2024
@martimlobao
Copy link
Author

Thanks for spotting this. Can you delete scripts.cfg instead? I don't know why it exists by itself.

All done :)

Copy link
Owner

@lra lra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lra
Copy link
Owner

lra commented Apr 19, 2024

I need to fix some CI errors before merging, I'll merge when this is fixed on master.

@martimlobao
Copy link
Author

@lra LMK if this needs any more changes or if we can kick off the checks to get this merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants