Backup/restore specific applications #2034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamelas
changed the title
McCio
reviewed
Aug 10, 2024
|
|
||
| # To allow for specific applications to be backed up, we replace the full list with only the valid ones from the command line | ||
| if args["<application>"]: | ||
| applications = list(set(args["<application>"]) & set(applications)) |
There was a problem hiding this comment.
should it fail here if any explicit application is not recognized?
silent ignoring them seems dangerous, as it would imply everything went fine
There was a problem hiding this comment.
it should also be sorted again, to maintain the same behaviour
McCio
reviewed
Aug 10, 2024
| @@ -179,8 +197,8 @@ def printAppHeader(app_name): | |||
|
|
|||
| elif args["show"]: | |||
| mckp.check_for_usable_environment() | |||
| app_name = args["<application>"] | |||
|
|
|||
| app_name = args["<application>"][0] # Needed because args["<application>"] is now a list | |||
There was a problem hiding this comment.
why not support multiple applications also in show command?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick take at allowing backup/restore of specific applications. I found it useful for myself and found at least two people requesting it on #2019 and #1892. I'll try to add the option to do the same with the uninstall command in the future.
All submissions
Adding/updating Application X Support
Improving the Mackup codebase